This is due the fact that Ansible often takes another default shell
to execute its commands, e.g., /bin/sh.
Solution is to require /bin/bash for the particular command.
In check_mode, the binary download task depends on the execution of the
previous one, which uses the module shell to fill in a variable. In the
download binary task we use a field on that variable that does not exist
in check_mode, so the task fails.
Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es>
Update gitea:
https://github.com/go-gitea/gitea/releases
What changed:
> 1.9.3
BUGFIXES
Fix go get from a private repository with Go 1.13 (#8100)
Strict name matching for Repository.GetTagID() (#8082)
Avoid ambiguity of branch/directory names for the git-diff-tree command (#8070)
Add change title notification for issues (#8064)
Run CORS handler first for /api routes (#7967) (#8053)
Evaluate emojis in commit messages in list view (#8044)
Fix failed to synchronize tags to releases for repository (#7990) (#7994)
Fix adding default Telegram webhook (#7972) (#7992)
Abort synchronization from LDAP source if there is some error (#7965)
Fix deformed emoji in commit message (#8071)
ENHANCEMENT
Keep blame view buttons sequence consistent with normal view when viewing a file (#8007) (#8009)
> 1.9.2
BUGFIXES
Fix wrong sender when send slack webhook (#7918) (#7924)
Upload support text/plain; charset=utf8 (#7899)
Lfs/lock: round locked_at timestamp to second (#7872) (#7875)
Fix non existent milestone with 500 error (#7867) (#7873)
SECURITY
Fix No PGP signature on 1.9.1 tag (#7874)
Release built with go 1.12.9 to fix security fixes in golang std lib, ref: https://groups.google.com/forum/#!msg/golang-announce/oeMaeUnkvVE/a49yvTLqAAAJ
ENHANCEMENT
Fix pull creation with empty changes (#7920) (#7926)
BUILD
Drone/docker: prepare multi-arch release + provide arm64 image (#7571) (#7884)
> 1.9.1
BREAKING
Add pagination for admin api get orgs and fix only list public orgs bug (#7742) (#7752)
SECURITY
Be more strict with git arguments (#7715) (#7762)
Release built with go 1.12.8 to fix security fixes in golang std lib, ref: https://groups.google.com/forum/#!topic/golang-nuts/fCQWxqxP8aA
BUGFIXES
Fix local runs of ssh-requiring integration tests (#7855) (#7857)
Fix hook problem (#7856) (#7754)
Use .ExpiredUnix.IsZero to display green color of forever valid gpg key (#7850) (#7846)
Do not fetch all refs (#7797) (#7837)
Fix duplicate call of webhook (#7824) (#7821)
Enable switching to a different source branch when PR already exists (#7823)
Rewrite existing repo units if setting is not included in api body (#7811)
Prevent Commit Status and Message From Overflowing On Branch Page (#7800) (#7808)
API: fix multiple bugs with statuses endpoints (Backport #7785) (#7807)
Fix Slack webhook fork message (1.9 release backport) (#7783)
Fix approvals counting (#7757) (#7777)
Fix rename failed when rewrite public keys (#7761) (#7769)
Fix dropTableColumns sqlite implementation (#7710) (#7765)
Fix repo_index_status lingering when deleting a repository (#7738)
Fix milestone completness calculation when migrating (#7725) (#7732)
Fixes indexed repos keeping outdated indexes when files grow too large (#7731)
Skip non-regular files (e.g. submodules) on repo indexing (#7717)
Improve branches list performance and fix protected branch icon when no-login (#7695) (#7704)
Correct wrong datetime format for git (#7689) (#7690)
I kicked out some config values, that are not controlled via ansible variables.
Maybe it makes more sense if we only customize the values, we are really changing. *(like database, domain and other behavior...)*
I had the problem, that after upgrading gitea it won't run with the config provided by this ansible role. But the default config worked fine.
I assume that the official gitea chenged and updated some options.
Some options in the old config file of this role did not appear in the [official cheat sheet](https://docs.gitea.io/en-us/config-cheat-sheet/).
@thomas-maurice: What did you think about it?
Better track every value and update it in our config.
Or clean up the config and only keep the parameter we really need and let gitea set everything else with their default values?
ANsible comes with the error:
```bash
[DEPRECATION WARNING]: evaluating gitea_fail2ban_enabled as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This
feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
```
appending ``|bool`` after a boolean variable will resolve the issue.
Old behavior is to download the binary of `gitea_version` every run,
then checksum it against the currently installed version to see if it needs
to be copied over.
New behavior is to attempt to extract the current running version of gitea
and only initiate the old behavior if the running version != `gitea_version`.
Default is old behavior due to the major logic change involved.
